Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename named top-level prop from id to flagSetId #177

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat: rename named top-level prop from id to flagSetId #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion json/flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"title": "Flag Set Metadata",
"description": "Metadata about the flag set, with keys of type string, and values of type boolean, string, or number.",
"properties": {
"id": {
"flagSetId": {
"description": "The unique identifier for the flag set.",
"type": "string"
},
Expand Down
2 changes: 1 addition & 1 deletion json/flags.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ properties:
title: Flag Set Metadata
description: Metadata about the flag set, with keys of type string, and values of type boolean, string, or number.
properties:
id:
flagSetId:
description: The unique identifier for the flag set.
type: string
version:
Expand Down
2 changes: 1 addition & 1 deletion json/test/flags/positive/with-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
}
},
"metadata": {
"id": "sso/dev",
"flagSetId": "sso/dev",
"version": "1.0.0",
"boolean": true,
"string": "string",
Expand Down
Loading