-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launchpad): adding a launchpad to control flagd #194
Merged
aepfli
merged 6 commits into
open-feature:main
from
open-feature-forking:feat/launchpad
Jan 20, 2025
Merged
feat(launchpad): adding a launchpad to control flagd #194
aepfli
merged 6 commits into
open-feature:main
from
open-feature-forking:feat/launchpad
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #190 |
aepfli
force-pushed
the
feat/launchpad
branch
3 times, most recently
from
January 16, 2025 22:15
058a0a1
to
928544e
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/launchpad
branch
from
January 16, 2025 22:16
928544e
to
b5e3688
Compare
chrfwow
reviewed
Jan 17, 2025
chrfwow
approved these changes
Jan 17, 2025
warber
reviewed
Jan 17, 2025
beeme1mr
approved these changes
Jan 17, 2025
beeme1mr
changed the title
feat(launchpad): adding a launchpad to controll flagd
feat(launchpad): adding a launchpad to control flagd
Jan 17, 2025
Co-authored-by: warber <72415058+warber@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Co-authored-by: warber <72415058+warber@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Co-authored-by: warber <72415058+warber@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Co-authored-by: warber <72415058+warber@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/launchpad
branch
from
January 19, 2025 16:58
d50d6e9
to
551d5d2
Compare
toddbaert
reviewed
Jan 20, 2025
|
||
ENTRYPOINT ["sh", "change-flag-wrapper.sh", "./flagd", "start", \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may as well delete the wrapper.
toddbaert
approved these changes
Jan 20, 2025
Co-authored-by: warber <72415058+warber@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/launchpad
branch
from
January 20, 2025 16:50
551d5d2
to
e67b7e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how to test
curl command to fetch changing flag
you can start/stop based on the endpoints provided, or change the flag and verify with the above curl command if it works or not. (either via browser or curl) http://localhost:8080/[start|stop|change](?config=(default|ssl))