Skip to content

Conversation

@toddbaert
Copy link
Member

Mentions the debounce hook in react/angular docs where it's particularly applicable due to render-lifecycles.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested review from a team as code owners October 24, 2025 18:43
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @toddbaert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation for both the React and Angular SDKs. It introduces new sections that address observability concerns related to feature flag evaluations, specifically how the inherent lifecycles of these frameworks can lead to redundant metric reporting. The updates provide guidance and recommend the use of the OpenFeature debounce hook to ensure more accurate telemetry.

Highlights

  • Angular Documentation Update: A new section on "Observability considerations" has been added to the Angular SDK README, detailing how Angular's lifecycle can cause inflated flag evaluation metrics.
  • React Documentation Update: A new section on "Observability Considerations" has been added to the React SDK README, addressing similar issues with React's lifecycle and flag evaluations.
  • Debounce Hook Recommendation: Both new documentation sections recommend using the OpenFeature debounce hook to limit the frequency of reported evaluation metrics, providing a link to its repository.
  • Table of Contents Refinement: The Angular SDK README's table of contents was updated to reflect new and reorganized sections, including "Structural Directives", "FeatureFlagService", "Setting evaluation context", and "Observability considerations".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds important information to the Angular and React SDK documentation regarding observability. It warns users about potentially inflated evaluation metrics due to component lifecycles and suggests using the OpenFeature debounce hook as a solution. My feedback includes suggestions to add code examples to both README files to make the documentation more actionable for developers.

@beeme1mr beeme1mr merged commit 27666b8 into main Oct 28, 2025
10 checks passed
@beeme1mr beeme1mr deleted the feat/debounce-hooks-docs branch October 28, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants