- 
                Notifications
    You must be signed in to change notification settings 
- Fork 45
chore: mention debounce hook in react/ng docs #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
| Summary of ChangesHello @toddbaert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for both the React and Angular SDKs. It introduces new sections that address observability concerns related to feature flag evaluations, specifically how the inherent lifecycles of these frameworks can lead to redundant metric reporting. The updates provide guidance and recommend the use of the OpenFeature debounce hook to ensure more accurate telemetry. Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds important information to the Angular and React SDK documentation regarding observability. It warns users about potentially inflated evaluation metrics due to component lifecycles and suggests using the OpenFeature debounce hook as a solution. My feedback includes suggestions to add code examples to both README files to make the documentation more actionable for developers.
Mentions the debounce hook in react/angular docs where it's particularly applicable due to render-lifecycles.