-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update how react technology selection is handled #982
base: main
Are you sure you want to change the base?
feat: update how react technology selection is handled #982
Conversation
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b9a0a66
to
d0e473f
Compare
src/datasets/providers/devcycle.ts
Outdated
@@ -36,7 +36,7 @@ export const DevCycle: Provider = { | |||
category: ['Client'], | |||
}, | |||
{ | |||
technology: 'React', | |||
technology: ['React', 'JavaScript'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this create duplicate providers in the ecosystem page? Perhaps that's okay but it would artificially inflate the numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
…e to 20 Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
…gies. Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
34d0156
to
d05f743
Compare
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
This PR
Technology
section to have child technology SDKs likeReact
,Angular
,NestJS
show in the Technology list.React
is selected, it will show the React SDK, all providers from a vendor marked as theirReact
provider (and exclude their base Web provider), and all other vendors' web providers.React
they just need to set theirtechnology
andparentTechnology
as so:allTechnologies
field that lists the multiple technologies a provider should be filterable for. It does not add multiple records to the search hits.