Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update how react technology selection is handled #982

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Feb 13, 2025

This PR

  • Updates the Technology section to have child technology SDKs like React, Angular, NestJS show in the Technology list.
    • When a child technology like React is selected, it will show the React SDK, all providers from a vendor marked as their React provider (and exclude their base Web provider), and all other vendors' web providers.
    • For Vendors to add specific docs for a child technology Provider like React they just need to set their technology and parentTechnology as so:
{
      ...
      technology: 'React',
      parentTechnology: 'JavaScript',
}
  • These updates are mostly handled through adding an allTechnologies field that lists the multiple technologies a provider should be filterable for. It does not add multiple records to the search hits.
  • Updated the number of search hits visible on the page to 20 as the number of providers has grown.
image

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for openfeature ready!

Name Link
🔨 Latest commit 61e6719
🔍 Latest deploy log https://app.netlify.com/sites/openfeature/deploys/67afa55855827200081e6e35
😎 Deploy Preview https://deploy-preview-982--openfeature.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathannorris jonathannorris force-pushed the feat-update-react-handling branch from b9a0a66 to d0e473f Compare February 13, 2025 17:25
@@ -36,7 +36,7 @@ export const DevCycle: Provider = {
category: ['Client'],
},
{
technology: 'React',
technology: ['React', 'JavaScript'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this create duplicate providers in the ecosystem page? Perhaps that's okay but it would artificially inflate the numbers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the latest changes, it doesn't create duplicate entries if a provider has a React provider and a base web provider:
image

@jonathannorris jonathannorris marked this pull request as ready for review February 14, 2025 16:45
@jonathannorris jonathannorris requested a review from a team as a code owner February 14, 2025 16:45
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
…e to 20

Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
…gies.

Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
@jonathannorris jonathannorris force-pushed the feat-update-react-handling branch from 34d0156 to d05f743 Compare February 14, 2025 16:46
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants