Skip to content

Commit

Permalink
feat: pr feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
  • Loading branch information
lukas-reining committed Nov 19, 2024
1 parent b9d427c commit 86620c2
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions openfeature/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
from openfeature.provider import FeatureProvider
from openfeature.provider._registry import provider_registry
from openfeature.provider.metadata import Metadata
from openfeature.transaction_context import (
from openfeature.transaction_context import TransactionContextPropagator
from openfeature.transaction_context.no_op_transaction_context_propagator import (
NoOpTransactionContextPropagator,
TransactionContextPropagator,
)

__all__ = [
Expand Down
1 change: 0 additions & 1 deletion openfeature/transaction_context/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@

__all__ = [
"TransactionContextPropagator",
"NoOpTransactionContextPropagator",
"ContextVarsTransactionContextPropagator",
]
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,5 @@ class NoOpTransactionContextPropagator(TransactionContextPropagator):
def get_transaction_context(self) -> EvaluationContext:
return EvaluationContext()

def set_transaction_context(
self, transaction_context: EvaluationContext
) -> None:
pass
def set_transaction_context(self, transaction_context: EvaluationContext) -> None:
pass

Check warning on line 12 in openfeature/transaction_context/no_op_transaction_context_propagator.py

View check run for this annotation

Codecov / codecov/patch

openfeature/transaction_context/no_op_transaction_context_propagator.py#L12

Added line #L12 was not covered by tests
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import typing
from typing import TypeVar

from openfeature.evaluation_context import EvaluationContext

T = TypeVar("T", bound="TransactionContextPropagator")


class TransactionContextPropagator(typing.Protocol):
def get_transaction_context(self) -> EvaluationContext: ...
Expand Down

0 comments on commit 86620c2

Please sign in to comment.