-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: optimize GitHub CI workflow #220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 16 16
Lines 440 440
=======================================
Hits 412 412
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
658f6cf
to
a499cd9
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
15ebf19
to
b841817
Compare
b841817
to
2a62fc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good but do you need two separate files? I believe you should be able to update one of the files to support either trigger. It also may not be necessary to run at all on a merge to main since it was tested during the PR process.
Indeed, I just didn't want to change too much before validating the approach. Will update the PR. |
a7ead47
to
809d3d5
Compare
2d5723c
to
e6dd89b
Compare
Not sure where those missing build status come from 🤔 |
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Federico Bond <federicobond@gmail.com>
e6dd89b
to
fa2d7e2
Compare
I can't quite understand it either. I wonder if it's just an artifact of the changes and once it's merged it will work subsequently? |
@toddbaert the problem is that it does not let me merge without every status check passing. I will open a separate PR to see if that solves it. |
@toddbaert I think it MIGHT have to do with some of these checks being marked as required and GH not preserving the mapping from the previous configuration. Do you have permission to disable them temporarily and then enable the new ones? |
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@federicobond we had branch protection enabled that look for the old job names. |
This PR
Optimizes our GH workflows by running linters like black/flake8 and CodeQL in a separate job with a single Python version, drastically reducing the feedback time for builds. Tests still run on a version matrix.
It also removes the virtualenv configuration which is not necessary in CI since the machines are ephemeral anyway, and uses the official Python setup actions instead of Docker to further reduce the number of layers involved in the execution of the build.
TODO: