feat(go-feature-flag): Support exporter metadata #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
goff-exporter-metadata
branch
from
4543a8d to
c58f3ab
Compare
thomaspoignant
commented
Jan 24, 2025
| @@ -35,6 +35,11 @@ def evaluate(flag_key:, default_value:, allowed_classes:, evaluation_context: ni | |||
| evaluation_context = OpenFeature::SDK::EvaluationContext.new if evaluation_context.nil? | |||
| validate_parameters(flag_key, evaluation_context) | |||
|
|
|||
| # enrich the evaluation context with the exporter_metadata | |||
| @options.exporter_metadata ||= {} | |||
| @options.exporter_metadata.merge!({"openfeature" => true, "provider" => "ruby"}) | |||
There was a problem hiding this comment.
Those are default exporter_metadata values that are added for every evaluation.
There was a problem hiding this comment.
Because I need them in the GO Feature Flag server, and since I am using the OFREP API and I have no other fields than the context to add those extra informations.
There was a problem hiding this comment.
I could have put it as a header, but the problem is the limit in header size that we may reach.
There was a problem hiding this comment.
Ah, I see. That's a clever workaround 😄
beeme1mr
approved these changes
Jan 24, 2025
|
Will give this a review today when I have a chance |
maxveldink
approved these changes
Jan 24, 2025
providers/openfeature-go-feature-flag-provider/lib/openfeature/go-feature-flag/options.rb
Outdated
Show resolved
Hide resolved
...feature-go-feature-flag-provider/lib/openfeature/go-feature-flag/go_feature_flag_provider.rb
Outdated
Show resolved
Hide resolved
providers/openfeature-go-feature-flag-provider/spec/openfeature/gofeatureflag/provider_spec.rb
Show resolved
Hide resolved
providers/openfeature-go-feature-flag-provider/spec/openfeature/gofeatureflag/provider_spec.rb
Show resolved
Hide resolved
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
pushed a commit
that referenced
this pull request
Jan 27, 2025
🤖 I have created a release *beep* *boop* --- ## [0.1.3](openfeature-go-feature-flag-provider/v0.1.2...openfeature-go-feature-flag-provider/v0.1.3) (2025-01-25) ### ✨ New Features * **go-feature-flag:** Support exporter metadata ([#45](#45)) ([04754fd](04754fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
In this PR we support
exporterMetadatathat will allow to add static information that will be added to your feature event sent to the GO Feature Flag exporter.In this PR we add those exporter metadata to the evaluation context in order to pass them to GO Feature Flag relay-proxy.
Related Issues
thomaspoignant/go-feature-flag#2983