✨ [open-formulieren/open-forms#5033] User friendly error in case of 503 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 604 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
+ Coverage 83.32% 83.66% +0.34%
==========================================
Files 239 240 +1
Lines 4750 4751 +1
Branches 1268 1273 +5
==========================================
+ Hits 3958 3975 +17
+ Misses 757 741 -16
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/5033-service-unavailable-error-message
branch
from
bd62356 to
c0ca478
Compare
stevenbal
commented
Jan 24, 2025
| }, | ||
| }; | ||
|
|
||
| // FIXME cant get this to work with routerprovider |
There was a problem hiding this comment.
This requires a Router because <Link> is used in the PermissionDeniedError component, but whenever I tried using the RouterProvider in Storybook it kept crashing the page...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#5033