Skip to content

Added MAINTAINERS.md #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added MAINTAINERS.md #4

wants to merge 2 commits into from

Conversation

hari-ajidesh
Copy link

Closes #3

@hari-ajidesh
Copy link
Author

Please add the hacktoberfest-accepted label to this issue

@joewxboy
Copy link
Member

@hari-ajidesh Your commit was not signed-off, so it cannot be merged. See if you can amend your commit to add the "Signed-off-by: " flag per https://open-horizon.github.io/common-requests/contribute.html

@hari-ajidesh
Updated MAINTAINERS.md
49c269a 
Added the signed-off comment as advised.
joewxboy
joewxboy requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like you added the "Signed-off-by" to the MAINTAINERS.md file instead of the commit comment. Please remove from that file and add to the commit:

git commit -s -m "[Commit message]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewxboy joewxboy joewxboy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MAINTAINERS.md file
2 participants
@hari-ajidesh @joewxboy