-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
surveys: archive individual survey (fixes #6620) #7807
Open
RheuX
wants to merge
13
commits into
master
Choose a base branch
from
6620-archive-close-surveys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RheuX
changed the title
surveys: archive individual survey
surveys: archive individual survey (fixes #6620)
Nov 26, 2024
jessewashburn
approved these changes
Nov 27, 2024
Gavinp14
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #6620 for number 2, archive/closingFixes #6620 number 2
just need to clean up the functions and logging statements, specifically for theforkJoin
Intended Behavior
You can now archive surveys,
Admin
Learner/User
I can't fix, might need to be a separate PR
I cannot put a tooltip down when the buttons are disabled, since I made most of the buttons disabled for archive.
Also, you can only archive for surveys that you created, im not sure about surveys related to a courses (since I think courses on survey should always be open)