resources: smoother collections closing (fixes #6882) #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gavinp14
approved these changes
Dec 17, 2024
RheuX
approved these changes
Dec 17, 2024
|
I'm not entirely happy with having three buttons in a single dialog. Perhaps we should simplify it by keeping only the 'Reset' and 'OK' buttons, as 'OK' can close the dialog. |
|
Updated so that the close button only appears if there is not another way to close the dialog (i.e. via the OK button) |
Mutugiii
approved these changes
Jan 23, 2025
dogi
changed the title
dogi
approved these changes
Jan 23, 2025
dogi
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6882
@dyeh123's PR #7001 was on a stale branch so recommend closing that one.