Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoother member role title (fixes #7966) #7970

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Gavinp14
Copy link
Member

fixes #7966

@Gavinp14 Gavinp14 linked an issue Dec 19, 2024 that may be closed by this pull request
Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you scroll down, there is still overflow.
image

@Gavinp14
Copy link
Member Author

@jessewashburn I decided to remove word break and just make it fixed on one line, I realized you need to leave room for the tasks user is assigned to. Let me know if it is still overflowing.

Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should allow for slightly longer titles since there is plenty of space
image

@Gavinp14
Copy link
Member Author

Gavinp14 commented Dec 20, 2024

@jessewashburn I agree there is plenty of room, however when a member is assigned more than two tasks, a member title that is more than two lines will cause overflow for the tasks as pictured below. I guess maybe this could be a separate issue in regard to the tasks list maybe. Could you please try to replicate this?
jesseResponse

@jessewashburn
Copy link
Member

jessewashburn commented Dec 20, 2024

@jessewashburn I agree there is plenty of room, however when a member is assigned more than two tasks, a member title that is more than two lines will cause overflow for the tasks as pictured below. I guess maybe this could be a separate issue in regard to the tasks list maybe. Could you please try to replicate this?

I see. Yes, that does happen, but it can also happen when there is a long name.
image
Rather than catering to the task overflow issue, I would set up the title truncation assuming that tasks will not over flow and then fix the tasks issue separately. Or fix it here if it's simple enough.

@Gavinp14
Copy link
Member Author

I will take a look and see what I can do, I might have to adjust some stuff in the task's component.

Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think you still need to add word break. Not sure if you intended to fix the tasks overflow here, but this is what it looks like for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

teams: member role overflow
2 participants