resources: smoother collections buttons (fixes #7986)(fixes #7990)#7989
Merged
resources: smoother collections buttons (fixes #7986)(fixes #7990)#7989
Conversation
jessewashburn
changed the title
Gavinp14
previously requested changes
Dec 23, 2024
Member
Gavinp14
left a comment
Gavinp14
left a comment
There was a problem hiding this comment.
This looks good, the only minor change would be to just move any overflowing names a bit to the left more so the parenthesis isn't cramped close to the edit button
Member
Author
Good catch. Please re-review. |
RheuX
approved these changes
Jan 13, 2025
Mutugiii
approved these changes
Jan 16, 2025
dogi
changed the title
dogi
approved these changes
Jan 16, 2025
dogi
approved these changes
Jan 16, 2025
Mutugiii
deleted the
7986-change-collections-buttons-cut-off-at-the-bottom
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7986, #7990
I made the Change Collections dialog match the formatting of the Collections dialog, including truncation and button spacing.
I fixed an issue where the number in parentheses was getting cut off by ellipsis truncation.
I moved the truncation from a method in the TS file to a CSS class, which is more dynamic on mobile.
I fixed the OK and Reset buttons, which were getting cut off.