voices: open link to specific post (fixes #8226) #8275
+88
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessewashburn
requested changes
Feb 26, 2025
There was a problem hiding this comment.
The linking works, but replying and editing messages require a refresh to see the changes. Also, deleting a reply doesn't seem to work at all. Eventually we should add a "Create link" button, but that could be a separate PR down the road.
screen-recorder-wed-feb-26-2025-16-14-30.webm
|
Technically those actions from non-authed users shouldn't be allowed and we should redirect for login (or a popup for login) -> #8225 |
Ah I see |
jessewashburn
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8226
Can test by using the copied link in an incognito browser
Needs #8225 to be complete to work with redirecting, as well as to standardize with #8228