Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fiscal sponsor projects to the site #889

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Sep 19, 2024

This PR fixes issue #869.
OLS's index fiscally sponsored community, RSE-AUNZ, has been added to the appropriate page (i.e .../open-incubator/fiscal-hosting/).

Changes made:

  • Created a new fiscal_communities array within the _data/community.yaml file and added data about RSE-AUNZ.
  • Wrote logic to add RSE-AUNZ to the bottom of the fiscal-hosting page.

Screenshot:
Screenshot (752)

Note for reviewers:

Thanks for the review!

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 7cfc3e8
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/671920c2764bb60008038bd7
😎 Deploy Preview https://deploy-preview-889--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NPDebs NPDebs added the enhancement New feature or request label Oct 7, 2024
oryx-build-commands.txt Outdated Show resolved Hide resolved
@@ -41,7 +41,7 @@ streams:
-
title: Fiscal Hosting
description: |
We are helping early stage organizations with fiscal hosting. If you are interested, please contact directors at we-are-ols.org to discuss.
We are helping early stage organizations with fiscal hosting. If you are interested, please contact directors at [team[at]we-are-ols.org](mailto:team@we-are-ols.org) to discuss. Read more about this on our [fiscal hosting page](/open-incubator/fiscal-hosting/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried if link and email variable from the _config.yaml work there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It typically doesn't work in the yaml frontmatter.

File doesn't belong in the main repo, but is a product of building the site in GitHub CodeSpaces.
@yochannah yochannah added the 🚨 merged-but-needs-review Merged for practical reasons (e.g. content needs to be on the site), but still needs a tech review. label Oct 23, 2024
Copy link
Member

@yochannah yochannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visually the change looks good - I'll merge but leave the tag to note that Bérénice may wish to review further.

@yochannah yochannah merged commit df62404 into open-life-science:main Oct 23, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🚨 merged-but-needs-review Merged for practical reasons (e.g. content needs to be on the site), but still needs a tech review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants