Skip to content

Commit

Permalink
Use selenium-firefox docker image version 2.53.1
Browse files Browse the repository at this point in the history
Also remove PROFILE env var in .travis.yml to prevent assumption that
changing its value to `firefox` will work (it won't if version remain 3).

Also add moodle dir mount to selenium container to allow running file upload
tests.
  • Loading branch information
kabalin committed May 17, 2020
1 parent 0b2090b commit 84c9a3a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .travis.dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ before_install:
- cd ../..
- composer create-project -n --no-dev --prefer-dist blackboard-open-source/moodle-plugin-ci ci ^2
- export PATH="$(cd ci/bin; pwd):$(cd ci/vendor/bin; pwd):$PATH"
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm selenium/standalone-firefox:3
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm -v $HOME/build/moodle:$HOME/build/moodle selenium/standalone-firefox:2.53.1

install:
- moodle-plugin-ci install
Expand Down
7 changes: 3 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,14 @@ env:
- MUSTACHE_IGNORE_NAMES=broken.mustache
- DB=pgsql
- MOODLE_BRANCH=master
- PROFILE=chrome

install:
- phpenv config-rm xdebug.ini
- nvm install 8.9
- nvm use 8.9
- make init
# Start Selenium Standalone with Chrome/Firefox installed.
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm selenium/standalone-${PROFILE}:3
# Start Selenium Standalone with Chrome.
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm -v $HOME/build/moodle:$HOME/build/moodle selenium/standalone-chrome:3
# Mimic how a Moodle plugin would be run.
- cp -R tests/Fixture/moodle-local_travis ../moodle-local_travis
- export PATH="$(cd bin; pwd):$(cd vendor/bin; pwd):$PATH"
Expand All @@ -54,7 +53,7 @@ script:
- moodle-plugin-ci grunt || [ "$MOODLE_BRANCH" != 'master' -a "$MOODLE_BRANCH" != 'MOODLE_38_STABLE' ]
- moodle-plugin-ci phpdoc
- moodle-plugin-ci phpunit --coverage-text
- moodle-plugin-ci behat --profile $PROFILE
- moodle-plugin-ci behat --profile chrome

jobs:
include:
Expand Down
2 changes: 1 addition & 1 deletion docs/TravisFileExplained.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ before_install:
# Start Selenium Standalone server with Chrome/Firefox installed. If you
# prefer to run Behat tests with Chrome profile (see Behat step details below),
# use selenium/standalone-chrome:3 image instead.
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm selenium/standalone-firefox:3
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm -v $HOME/build/moodle:$HOME/build/moodle selenium/standalone-firefox:2.53.1

# This lists steps that are run for installation and setup.
install:
Expand Down

0 comments on commit 84c9a3a

Please sign in to comment.