Minor: OSS requirements for the custom property automation action #19507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketkatkar97
added
UI
github-actions
bot
added
the
safe to test
Jest test CoverageUI tests summary
|
|
chirag-madlani
approved these changes
Feb 7, 2025
| @@ -27,6 +27,7 @@ export interface FetchOptionsResponse { | |||
|
|
|||
| export interface DataAssetAsyncSelectListProps { | |||
| mode?: 'multiple'; | |||
| autoFocus?: boolean; | |||
There was a problem hiding this comment.
recommended to enable selectProps instead so no need to add one by one
|
Changes have been cherry-picked to the 1.6.4 branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
…9507) * Fix the return type for the custom property API function * Break down the EditTableTypePropertyModal.tsx component * Fix the custom property inputs for date-time type properties * auto lint formatting changes * Add the autoFocus prop for DataAssetAsyncSelectList * Fix and add the unit tests for new code (cherry picked from commit 638e988)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on the following:
Date Timecustom property input not showing the minutes and seconds select list.Before:
Screen.Recording.2025-02-07.at.12.34.55.PM.mov
After:
Screen.Recording.2025-02-07.at.12.35.18.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>