Skip to content

feat: edit display name and delete functionalities for roles and policy #19612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 3, 2025
Merged

feat: edit display name and delete functionalities for roles and policy #19612

merged 16 commits into from
Feb 3, 2025

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Jan 30, 2025 •
edited
Loading

Describe your changes:

Fix #16702

Added below functionalities:

  • Edit display name for Role and Policy
  • Delete the Role and Policy
Screen.Recording.2025-01-31.at.10.53.24.AM.mov
Screen.Recording.2025-01-31.at.10.14.20.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 changed the title feat: rename and delete functionality for role feat: edit display name functionality for roles and policy Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 added the safe to test Add this label to run secure Github workflows on PRs label Jan 31, 2025
@pranita09 pranita09 marked this pull request as ready for review January 31, 2025 04:54
@pranita09 pranita09 requested a review from a team as a code owner January 31, 2025 04:54
chirag-madlani
chirag-madlani reviewed Jan 31, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pranita09 pranita09 merged commit f93bb1f into open-metadata:main Feb 3, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashish8689 Ashish8689 Ashish8689 left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Edit Name for roles and policy
4 participants
@pranita09 @chirag-madlani @Ashish8689 @ShaileshParmar11