Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application doc panel #19625

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Application doc panel #19625

merged 4 commits into from
Feb 5, 2025

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Add a documentation panel on Application Configuration Page.

Screenshot 2025-01-31 at 8 46 09 PM
Screenshot 2025-01-31 at 8 47 26 PM

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@karanh37 karanh37 requested a review from a team as a code owner January 31, 2025 15:17
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jan 31, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.51% (41068/63662) 40.76% (16468/40403) 44.05% (4991/11331)

@@ -16,7 +16,7 @@
"build": "webpack --config ./webpack.config.prod.js --env production",
"postinstall": "yarn run build-check",
"preinstall": "cd ../../../../.. && yarn install --frozen-lockfile",
"pre-commit": "lint-staged --concurrent false",
"pre-commit": "lint-staged --concurrent false && yarn generate:app-docs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -2023,6 +2023,7 @@
"join-team-success": "Team joined successfully!",
"leave-team-error": "Error while leaving the team!",
"leave-team-success": "Left the team successfully!",
"no-application-schema-found": "No application schema found for {{appName}}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update it with translated values

Copy link

sonarqubecloud bot commented Feb 4, 2025

@karanh37 karanh37 merged commit 14b3d41 into main Feb 5, 2025
17 of 18 checks passed
@karanh37 karanh37 deleted the application-doc-panel branch February 5, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants