Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix numpy bug on Colab #2505

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

#2504, #1939
Due to an incompatibility between the Colab platform and the pre-built xtcocotools PyPI package, it is necessary to compile xtcocotools from source on Colab

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis requested a review from jin-s13 July 3, 2023 03:01
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (c40a2d4) 80.74% compared to head (321ecd6) 80.75%.

❗ Current head 321ecd6 differs from pull request most recent head 993d75a. Consider uploading reports for the commit 993d75a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2505      +/-   ##
===========================================
+ Coverage    80.74%   80.75%   +0.01%     
===========================================
  Files          251      251              
  Lines        15218    15218              
  Branches      2636     2636              
===========================================
+ Hits         12288    12290       +2     
+ Misses        2263     2261       -2     
  Partials       667      667              
Flag Coverage Δ
unittests 80.75% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit c6424b8 into open-mmlab:dev-1.x Jul 4, 2023
9 checks passed
@Ben-Louis Ben-Louis deleted the fix-numpy-colab-conflict branch July 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants