Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove webcam API #2511

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis closed this Jul 4, 2023
@Ben-Louis Ben-Louis mentioned this pull request Jul 4, 2023
6 tasks
@Ben-Louis Ben-Louis reopened this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.46 🎉

Comparison is base (c6424b8) 80.70% compared to head (6f4b048) 81.17%.

❗ Current head 6f4b048 differs from pull request most recent head 7208da2. Consider uploading reports for the commit 7208da2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2511      +/-   ##
===========================================
+ Coverage    80.70%   81.17%   +0.46%     
===========================================
  Files          251      226      -25     
  Lines        15218    13963    -1255     
  Branches      2636     2415     -221     
===========================================
- Hits         12282    11334     -948     
+ Misses        2273     2011     -262     
+ Partials       663      618      -45     
Flag Coverage Δ
unittests 81.17% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/version.py 47.05% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 2ab56bc into open-mmlab:dev-1.x Jul 4, 2023
@Ben-Louis Ben-Louis deleted the remove-webcam-api branch July 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants