Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with newer Jetbrains versions #173

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

steffann
Copy link
Contributor

@steffann steffann commented Aug 12, 2024

Make this plugin compatible with newer JetBrains versions. Tested locally on GoLand 2024.2.

Description

Simple compatibility marker update.

Compatibility for ide 2024.2

Make this plugin compatible with newer JetBrains versions. Tested locally on GoLand 2024.2.

Signed-off-by: Sander Steffann <sander@steffann.nl>
@anderseknert
Copy link
Member

anderseknert commented Aug 13, 2024

Thanks! I don't have a lot of experience working with this project, but looking back at past upgrades, they've changed a lot more code to accomodate the new changes. The first 4 I could find:

Nothing like that needed here? @vgramer can you PTAL 👍

@steffann
Copy link
Contributor Author

All I can say is “it worked for me” and “it hasn’t crashed yet” ;)

I’m definitely not very experienced here! so don’t take my word for it

@anderseknert
Copy link
Member

Yeah, that makes two of us then 😊 I can imagine how there are additional checks made when actually publishing the plugin, but @vgramer would know. Let's hope he can chip in.

@vgramer vgramer self-requested a review August 16, 2024 06:10
@vgramer vgramer self-assigned this Aug 16, 2024
Copy link
Member

@vgramer vgramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support the last 3 versions which cover IIRC 90% of the usage. Hoever on the la release we made a mistake in the range and support only the last 2 versions. So this time the up grade is pretty simple.

@steffann thanks for the works

@vgramer vgramer merged commit 43c482f into open-policy-agent:master Aug 26, 2024
6 checks passed
@anderseknert
Copy link
Member

Very nice! Looking forward to using this extension once more 🙂

@marcelmindemann
Copy link

Hi! Are you waiting out for something else before releasing a new version to the Marketplace that includes this change? I would love to install this plugin via the Marketplace instead of building from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants