Add util.HasherMap #7363
Merged
Add util.HasherMap #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Feb 14, 2025
| nil, | ||
| ruleHash, | ||
| nil, | ||
| nil, |
There was a problem hiding this comment.
This is the one place we can't use HasherMap, as Rule doesn't implement Hash. A good reminder however of why the HasherMap is nicer to work with :)
This is a simpler version of util.TypedHashMap where the keys implement a `.Hash()` method and as such won't need one to be passed in, and where the values are largely ignored by the map. These maps are smaller / more performant, but most importantly, they are nicer to work with. Perf wise, this saves about 600k+ allocs and 40 MB allocated memory in `regal lint bundle`: ``` 1207614875 ns/op 3293454016 B/op 64802095 allocs/op 1197978125 ns/op 3256960504 B/op 64164871 allocs/op ``` Also: - Use `strings.Builder` instead of `fmt.Sprintf` in one location - Remove `ValueMap.Copy` as it was only used in a test Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler version of util.TypedHashMap where the keys implement a
.Hash()method and as such won't need one to be passed in, and where the values are largely ignored by the map. These maps are smaller / more performant, but most importantly, they are nicer to work with.Perf wise, this saves about 600k+ allocs and 40 MB allocated memory in
regal lint bundle:Also:
strings.Builderinstead offmt.Sprintfin one locationValueMap.Copyas it was only used in a test