Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
open-space-collective · Oct 12, 2023 · 1964a68 · 1964a68
1 parent 875c99d
commit 1964a68
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp b/src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
@@ -86,15 +86,15 @@ Vector6d BrouwerLyddaneMean::Cartesian(
     if ((coe.getEccentricity() > 0.99) || (coe.getEccentricity() < 0.0))
     {
         throw ostk::core::error::RuntimeError(
-            String::Format("BrouwerLyddaneMean is applicable only if 0.0 < Ecc: [{}] < 0.99.", coe.getEccentricity())
+            "BrouwerLyddaneMean is applicable only if 0.0 < Ecc: [{}] < 0.99.", coe.getEccentricity()
         );
     }
 
     const Real perigee = coe.getPeriapsisRadius().inMeters();
     if (perigee < 3000000.0)
     {
         throw ostk::core::error::RuntimeError(
-            String::Format("BrouwerLyddaneMean is applicable only if Perigee radius: [{}] > 3000000.0 m.", perigee)
+            "BrouwerLyddaneMean is applicable only if Perigee radius: [{}] > 3000000.0 m.", perigee
         );
     }
     if (perigee < 6378000.0)
@@ -111,9 +111,9 @@ Vector6d BrouwerLyddaneMean::Cartesian(
     const Real inclination_degrees = coe.getInclination().inDegrees();
     if (inclination_degrees > 180.0)
     {
-        throw ostk::core::error::RuntimeError(String::Format(
+        throw ostk::core::error::RuntimeError(
             "BrouwerLyddaneMean is applicable only if inclination: [{}] < 180.0 degrees.", inclination_degrees
-        ));
+        );
     }
 
     if ((58.80 < inclination_degrees && inclination_degrees < 65.78) ||

diff --git a/src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp b/src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
@@ -79,15 +79,15 @@ COE BrouwerLyddaneMeanLong::toCOE() const
     if (eccdp > 0.99)
     {
         throw ostk::core::error::RuntimeError(
-            String::Format("BrouwerLyddaneMeanLong is applicable only if 0.0 < Ecc: [{}] < 0.99.", eccdp)
+            "BrouwerLyddaneMeanLong is applicable only if 0.0 < Ecc: [{}] < 0.99.", eccdp
         );
     }
 
     const Real perigee = this->getPeriapsisRadius().inMeters();
     if (perigee < 3000000.0)
     {
         throw ostk::core::error::RuntimeError(
-            String::Format("BrouwerLyddaneMeanLong is applicable only if Perigee radius: [{}] > 3000000.0 m.", perigee)
+            "BrouwerLyddaneMeanLong is applicable only if Perigee radius: [{}] > 3000000.0 m.", perigee
         );
     }
     if (perigee < 6378000.0)
@@ -103,10 +103,10 @@ COE BrouwerLyddaneMeanLong::toCOE() const
 
     if (incdp > Real::Pi())
     {
-        throw ostk::core::error::RuntimeError(String::Format(
+        throw ostk::core::error::RuntimeError(
             "BrouwerLyddaneMeanLong is applicable only if inclination: [{}] < 180.0 degrees.",
             Angle::Radians(incdp).inDegrees()
-        ));
+        );
     }
 
     const Real bk2 = (1.0 / 2.0) * (j2 * ae * ae);

diff --git a/...OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.cpp b/...OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.cpp
@@ -67,10 +67,10 @@ COE BrouwerLyddaneMeanShort::toCOE() const
 
     if ((incp < 0.0) || (incp > Real::Pi()))
     {
-        throw ostk::core::error::RuntimeError(String::Format(
+        throw ostk::core::error::RuntimeError(
             "BrouwerLyddaneMeanShort is applicable only if 0.0 < inclination: [{}] < 180.0 degrees.",
             Angle::Radians(incp).inDegrees()
-        ));
+        );
     }
 
     if (incp > 3.0543261909900763)
@@ -98,15 +98,15 @@ COE BrouwerLyddaneMeanShort::toCOE() const
     if (eccp > 0.99)
     {
         throw ostk::core::error::RuntimeError(
-            String::Format("BrouwerLyddaneMeanShort is applicable only if 0.0 < Ecc: [{}] < 0.99.", eccp)
+            "BrouwerLyddaneMeanShort is applicable only if 0.0 < Ecc: [{}] < 0.99.", eccp
         );
     }
 
     const Real perigee = this->getPeriapsisRadius().inMeters();
     if (perigee < 3000000.0)
     {
         throw ostk::core::error::RuntimeError(
-            String::Format("BrouwerLyddaneMeanShort is applicable only if Perigee radius: [{}] > 3000000.0 m.", perigee)
+            "BrouwerLyddaneMeanShort is applicable only if Perigee radius: [{}] > 3000000.0 m.", perigee
         );
     }
     if (perigee < 6378000.0)