feat: add backward propagation get pass with rev number (#410)

* feat: add reverse proapgation for orbit.getPassWithNumber

* feat: ensure it works with a seeded pass

* refactor: simplify forward backward propagation

* feat: address remaining feedback

* feat: simplify further

* feat: cleanup

* feat: python bindings

* chore: fix pass test

* Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* feat: address comments

---------

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Trajectory/Orbit/Pass.cpp

@@ -135,6 +135,28 @@ inline void OpenSpaceToolkitAstrodynamicsPy_Trajectory_Orbit_Pass(pybind11::modu
 
             )doc"
         )
+        .def(
+            "get_start_instant",
+            &Pass::getStartInstant,
+            R"doc(
+                Get the start instant of the pass. For partial passes, this is the minimum defined instant.
+
+                Returns:
+                    Instant: The start instant of the pass.
+            
+            )doc"
+        )
+        .def(
+            "get_end_instant",
+            &Pass::getEndInstant,
+            R"doc(
+                Get the end instant of the pass. For partial passes, this is the maximum defined instant.
+
+                Returns:
+                    Instant: The end instant of the pass.
+
+            )doc"
+        )
         .def(
             "get_instant_at_ascending_node",
             &Pass::accessInstantAtAscendingNode,

bindings/python/test/trajectory/orbit/test_pass.py

@@ -41,6 +41,12 @@ def test_get_revolution_number(self, pass_: Pass):
     def test_get_duration(self, pass_: Pass):
         assert pass_.get_duration() is not None
 
+    def test_get_start_instant(self, pass_: Pass):
+        assert pass_.get_start_instant() is not None
+
+    def test_get_end_instant(self, pass_: Pass):
+        assert pass_.get_end_instant() is not None
+
     def test_get_instant_at_ascending_node(self, pass_: Pass):
         assert pass_.get_instant_at_ascending_node() is not None
 

include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Pass.hpp

@@ -113,6 +113,16 @@ class Pass
     /// @return The duration of the pass.
     Duration getDuration() const;
 
+    /// @brief Get the start instant of the pass. For partial passes, this is the minimum defined instant.
+    ///
+    /// @return The start instant of the pass.
+    Instant getStartInstant() const;
+
+    /// @brief Get the end instant of the pass. For partial passes, this is the maximum defined instant.
+    ///
+    /// @return The end instant of the pass.
+    Instant getEndInstant() const;
+
     /// @brief Accesses the instant at the ascending node of the pass.
     ///
     /// @return The instant at the ascending node of the pass.