chore: implement nit MR suggestions

open-space-collective · Oct 11, 2023 · 68e6de1 · 68e6de1
1 parent b54f953
commit 68e6de1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/include/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.hpp b/include/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.hpp
@@ -137,6 +137,7 @@ class StateBuilder
     /// @param                  [in] aCoordinatesSubsetSPtr The CoordinatesSubset to remove
     ///
     /// @return                 A new StateBuilder
+
     const StateBuilder contract(const Shared<const CoordinatesSubset>& aCoordinatesSubsetSPtr) const;
 
     /// @brief                  Get an undefined StateBuilder.

diff --git a/src/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.cpp b/src/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.cpp
@@ -154,7 +154,7 @@ const StateBuilder StateBuilder::expand(const Shared<const CoordinatesSubset>& a
 
     if (this->coordinatesBrokerSPtr_->hasSubset(aCoordinatesSubsetSPtr))
     {
-        throw ostk::core::error::runtime::Wrong("CoordinatesSubset");
+        throw ostk::core::error::RuntimeError("Duplicate CoordinatesSubset");
     }
 
     Array<Shared<const CoordinatesSubset>> expandedSubsets = Array<Shared<const CoordinatesSubset>>::Empty();
@@ -176,7 +176,7 @@ const StateBuilder StateBuilder::contract(const Shared<const CoordinatesSubset>&
 
     if (!this->coordinatesBrokerSPtr_->hasSubset(aCoordinatesSubsetSPtr))
     {
-        throw ostk::core::error::runtime::Wrong("CoordinatesSubset");
+        throw ostk::core::error::RuntimeError("Missing CoordinatesSubset");
     }
 
     Array<Shared<const CoordinatesSubset>> contractedSubsets = Array<Shared<const CoordinatesSubset>>::Empty();

diff --git a/test/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.test.cpp b/test/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.test.cpp
@@ -417,7 +417,7 @@ TEST_F(OpenSpaceToolkit_Astrodynamics_Trajectory_StateBuilder, contract)
     {
         const StateBuilder stateBuilder = StateBuilder::Undefined();
 
-        EXPECT_ANY_THROW(stateBuilder.expand(CartesianPosition::Default()));
+        EXPECT_ANY_THROW(stateBuilder.contract(CartesianPosition::Default()));
     }
 
     {
-Original file line number
+Diff line change
@@ Expand Up @@
         {
             const StateBuilder stateBuilder = StateBuilder::Undefined();
-            EXPECT_ANY_THROW(stateBuilder.expand(CartesianPosition::Default()));
+            EXPECT_ANY_THROW(stateBuilder.contract(CartesianPosition::Default()));
         }
         {
@@ Expand Down @@