refactor: adress MR comments

open-space-collective · Oct 11, 2023 · 6edc53a · 6edc53a
1 parent 75e08ca
commit 6edc53a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/include/OpenSpaceToolkit/Astrodynamics/Trajectory/State.hpp b/include/OpenSpaceToolkit/Astrodynamics/Trajectory/State.hpp
@@ -59,7 +59,8 @@ class State
     );
 
     /// @brief                  Constructor. This constructor makes a new Coordinates Broker under the hood for every
-    /// State.
+    /// State. When possible, users should prefer passing in an existing Coordinates Broker or using a StateBuilder to
+    /// reduce memory footprint when constructing many states.
     ///
     /// @param                  [in] anInstant An instant
     /// @param                  [in] aCoordinates The coordinates at the instant in International System of Units

diff --git a/test/OpenSpaceToolkit/Astrodynamics/Trajectory/State.test.cpp b/test/OpenSpaceToolkit/Astrodynamics/Trajectory/State.test.cpp
@@ -47,6 +47,11 @@ TEST(OpenSpaceToolkit_Astrodynamics_Trajectory_State, Constructor)
             CartesianPosition::Default(), CartesianVelocity::Default()
         };
         EXPECT_NO_THROW(State state(instant, coordinates, Frame::GCRF(), subsets));
+
+        const State state(instant, coordinates, Frame::GCRF(), subsets);
+
+        EXPECT_EQ(state.extractCoordinates(CartesianPosition::Default()), coordinates.segment(0, 3));
+        EXPECT_EQ(state.extractCoordinates(CartesianVelocity::Default()), coordinates.segment(3, 3));
     }
 
     {