fix: fix missing binding for Segment::Solution (#253)

open-space-collective · Oct 17, 2023 · 8907f7d · 8907f7d
1 parent d4aae19
commit 8907f7d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Trajectory/Segment.cpp b/bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Trajectory/Segment.cpp
@@ -29,6 +29,7 @@ inline void OpenSpaceToolkitAstrodynamicsPy_Trajectory_Segment(pybind11::module&
 
         .def("get_initial_mass", &Segment::Solution::getInitialMass)
         .def("get_final_mass", &Segment::Solution::getFinalMass)
+        .def("get_propagation_duration", &Segment::Solution::getPropagationDuration)
 
         .def("compute_delta_mass", &Segment::Solution::computeDeltaMass)
         .def("compute_delta_v", &Segment::Solution::computeDeltaV, arg("specific_impulse"))

diff --git a/include/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.hpp b/include/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.hpp
@@ -70,6 +70,7 @@ class Segment
 
         Mass getInitialMass() const;
         Mass getFinalMass() const;
+        Duration getPropagationDuration() const;
 
         Real computeDeltaV(const Real& aSpecificImpulse) const;
         Mass computeDeltaMass() const;

diff --git a/src/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.cpp b/src/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.cpp
@@ -64,6 +64,11 @@ Mass Segment::Solution::getInitialMass() const
     return Mass::Kilograms(states.accessFirst().extractCoordinates(CoordinatesSubset::Mass())[0]);
 }
 
+Duration Segment::Solution::getPropagationDuration() const
+{
+    return accessEndInstant() - accessStartInstant();
+}
+
 Mass Segment::Solution::getFinalMass() const
 {
     if (states.isEmpty())

diff --git a/test/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.test.cpp b/test/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.test.cpp
@@ -145,6 +145,7 @@ TEST_F(OpenSpaceToolkit_Astrodynamics_Trajectory_Segment, SegmentSolution_Getter
 
         EXPECT_THROW(segmentSolution.getInitialMass(), ostk::core::error::RuntimeError);
         EXPECT_THROW(segmentSolution.getFinalMass(), ostk::core::error::RuntimeError);
+        EXPECT_THROW(segmentSolution.getPropagationDuration(), ostk::core::error::RuntimeError);
     }
 
     {
@@ -154,6 +155,7 @@ TEST_F(OpenSpaceToolkit_Astrodynamics_Trajectory_Segment, SegmentSolution_Getter
 
         EXPECT_DOUBLE_EQ(200.0, segmentSolution.getInitialMass().inKilograms());
         EXPECT_DOUBLE_EQ(180.0, segmentSolution.getFinalMass().inKilograms());
+        EXPECT_DOUBLE_EQ(0.0, segmentSolution.getPropagationDuration().inSeconds());
     }
 }