refactor: rename state method in python to build_state

open-space-collective · Oct 11, 2023 · dc123c0 · dc123c0
1 parent c6d4096
commit dc123c0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Trajectory/StateBuilder.cpp b/bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Trajectory/StateBuilder.cpp
@@ -36,7 +36,7 @@ inline void OpenSpaceToolkitAstrodynamicsPy_Trajectory_StateBuilder(pybind11::mo
 
         .def("is_defined", &StateBuilder::isDefined)
 
-        .def("state", &StateBuilder::buildState)
+        .def("build_state", &StateBuilder::buildState)
 
         .def("get_coordinates_subsets", &StateBuilder::getCoordinatesSubsets)
         .def("get_frame", &StateBuilder::getFrame)

diff --git a/bindings/python/test/trajectory/test_state_builder.py b/bindings/python/test/trajectory/test_state_builder.py
@@ -79,7 +79,7 @@ def test_build_state(
         state_builder: StateBuilder,
     ):
         coordinates = [1, 2, 3, 1, 2, 3]
-        state: State = state_builder.state(instant, coordinates)
+        state: State = state_builder.build_state(instant, coordinates)
 
         assert state is not None
         assert isinstance(state, State)

diff --git a/test/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.test.cpp b/test/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.test.cpp
@@ -82,6 +82,7 @@ TEST_F(OpenSpaceToolkit_Astrodynamics_Trajectory_StateBuilder, EqualToOperator)
         const StateBuilder anotherStateBuilder = {Frame::GCRF(), posVelMassBrokerSPtr};
 
         EXPECT_FALSE(aStateBuilder == anotherStateBuilder);
+        EXPECT_FALSE(anotherStateBuilder == aStateBuilder);
     }
 
     {
-Original file line number
+Diff line change
@@ Expand Up @@
             const StateBuilder anotherStateBuilder = {Frame::GCRF(), posVelMassBrokerSPtr};
             EXPECT_FALSE(aStateBuilder == anotherStateBuilder);
+            EXPECT_FALSE(anotherStateBuilder == aStateBuilder);
         }
         {
@@ Expand Down @@