-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return conditional solution for segment and sequences #233
Merged
vishwa2710
merged 4 commits into
main
from
users/vishwa/sequences-pass-back-condition-solution
Oct 9, 2023
Merged
feat: return conditional solution for segment and sequences #233
vishwa2710
merged 4 commits into
main
from
users/vishwa/sequences-pass-back-condition-solution
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwa2710
force-pushed
the
users/vishwa/sequences-pass-back-condition-solution
branch
from
October 6, 2023 18:46
5ff075e
to
41d4096
Compare
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 62 62
Lines 4743 4743
=======================================
Hits 3927 3927
Misses 816 816
|
kyle-cochran
reviewed
Oct 6, 2023
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Propagator.hpp
Outdated
Show resolved
Hide resolved
test/OpenSpaceToolkit/Astrodynamics/Trajectory/Sequence.test.cpp
Outdated
Show resolved
Hide resolved
vishwa2710
commented
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Propagator.hpp
Outdated
Show resolved
Hide resolved
test/OpenSpaceToolkit/Astrodynamics/Trajectory/Sequence.test.cpp
Outdated
Show resolved
Hide resolved
kyle-cochran
approved these changes
Oct 9, 2023
vishwa2710
deleted the
users/vishwa/sequences-pass-back-condition-solution
branch
October 9, 2023 23:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.