Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions to extract multiple subsets at once. #234

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

kyle-cochran
Copy link
Contributor

Add
VectorXd State::extractCoordinates(const Array<Shared<const CoordinatesSubset>>& aCoordinatesSubsetsArray) const;

and

    VectorXd CoordinatesBroker::extractCoordinates(
        const VectorXd& aFullCoordinatesVector, const Array<Shared<const CoordinatesSubset>>& aCoordinatesSubsetsArray
    ) const;

to allow extracting multiple subsets at once.

This is a preliminary step for whatever State::contract/slice/etc. function we implement.

Also add doc-strings to the State class.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #234 (c1b6eaf) into main (4465595) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   82.79%   82.84%   +0.04%     
==========================================
  Files          62       62              
  Lines        4743     4756      +13     
==========================================
+ Hits         3927     3940      +13     
  Misses        816      816              
Files Coverage Δ
...penSpaceToolkit/Astrodynamics/Trajectory/State.cpp 100.00% <100.00%> (ø)
...trodynamics/Trajectory/State/CoordinatesBroker.cpp 95.38% <100.00%> (+0.94%) ⬆️

Copy link
Contributor

@vishwa2710 vishwa2710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Co-authored-by: Vishwa Shah <vishwa2710@gmail.com>
@kyle-cochran kyle-cochran merged commit 973343a into main Oct 9, 2023
@kyle-cochran kyle-cochran deleted the users/kyle/state-multiple-subsets branch October 9, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants