refactor: Use the built-in State method to extract coordinates #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-cochran
commented
Oct 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 82.84% 82.79% -0.05%
==========================================
Files 62 62
Lines 4756 4744 -12
==========================================
- Hits 3940 3928 -12
Misses 816 816
|
vishwa2710
approved these changes
Oct 9, 2023
apaletta3
reviewed
Oct 10, 2023
bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Trajectory/State.cpp
Outdated
Show resolved
Hide resolved
test/OpenSpaceToolkit/Astrodynamics/Trajectory/State/CoordinatesBroker.test.cpp
Outdated
Show resolved
Hide resolved
kyle-cochran
force-pushed
the
users/kyle/simplify-state-extraction
branch
from
f561f1d to
c55aebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the built-in State method to extract multiple subsets at once, which makes a private function in Propagator obsolete.
Also changes the Numerical Solver State to always be in the propagation Frame since we are always converting the coordinates to that Frame anyway. Otherwise if the input State ever had a different Frame that the Propagation Frame, it would just silently give you crazy numbers.