Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add State constructor with Array of Subsets #238

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

kyle-cochran
Copy link
Contributor

Adds a constructor to the State class to directly build a custom State from an Array of Subsets.

This constructor will presumably cause a larger memory footprint, but is more straightforward to use than the Broker constructor.

This downfall should be mitigated in Python with the introduction of the CustomState meta-class stuff.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #238 (6edc53a) into main (9b7810a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   82.79%   82.81%   +0.01%     
==========================================
  Files          62       62              
  Lines        4744     4748       +4     
==========================================
+ Hits         3928     3932       +4     
  Misses        816      816              
Files Coverage Δ
...penSpaceToolkit/Astrodynamics/Trajectory/State.cpp 100.00% <100.00%> (ø)

Copy link
Contributor

@phc1990 phc1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left minor comments.

@kyle-cochran kyle-cochran merged commit da64bba into main Oct 11, 2023
12 checks passed
@kyle-cochran kyle-cochran deleted the users/kyle/array-state-constructor branch October 11, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants