feat: enrich StateBuilder capabilities #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 83.01% 83.23% +0.22%
==========================================
Files 63 63
Lines 4804 4874 +70
==========================================
+ Hits 3988 4057 +69
- Misses 816 817 +1
|
kyle-cochran
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
These are good and I think we should keep them, but I think we will also need some additional functions to operate on the State.
I.e. given a high dimensional State and a low dimensional Builder, produce a low dimensional state
also:
given a low dimensional state, a high dimensional builder, and a default values state, produce a high dimensional state
include/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.hpp
Outdated
Show resolved
Hide resolved
test/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.test.cpp
Outdated
Show resolved
Hide resolved
phc1990
changed the title
kyle-cochran
approved these changes
Oct 11, 2023
vishwa2710
reviewed
Oct 11, 2023
test/OpenSpaceToolkit/Astrodynamics/Trajectory/StateBuilder.test.cpp
Outdated
Show resolved
Hide resolved
kyle-cochran
force-pushed
the
users/kyle/add-state-builder
branch
from
0600f2a to
00aa429
Compare
kyle-cochran
force-pushed
the
users/pau/add-state-builder-suggestions
branch
from
000a8cd to
b969467
Compare
phc1990
force-pushed
the
users/pau/add-state-builder-suggestions
branch
from
13f5ab5 to
250ed7a
Compare
phc1990
force-pushed
the
users/pau/add-state-builder-suggestions
branch
from
5abe6fd to
ff6b1ce
Compare
|
Rebased and ready for review, see updated description. |
vishwa2710
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
I will let @kyle-cochran have the final approval but this looks great to me!
kyle-cochran
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
StateBuilderfeatures:Additional:
buildState->buildState== comparator was not assessing number of coordinates