-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Brouwer-Lyddane Mean Long and Mean Short elements #240
Conversation
vishwa2710
commented
Oct 11, 2023
•
edited
Loading
edited
- Have to add bindings, will do so after the C++ code is reviewed and any name/flow changes are addressed.
- Have to add docstrings to C++ code as well
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 83.27% 83.39% +0.11%
==========================================
Files 63 66 +3
Lines 4886 5505 +619
==========================================
+ Hits 4069 4591 +522
- Misses 817 914 +97
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge addition! Might want to add validation tests against GMAT or Orekit? (at least one set of propagated and computed BL values to ensure this is good?)
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.hpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
...enSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.test.cpp
Show resolved
Hide resolved
...de/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thank you for the feedback. All the unit tests are compared to GMAT so I will put that in the comments.
...de/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.hpp
Outdated
Show resolved
Hide resolved
...enSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.test.cpp
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to simplify RuntimeError printing.
Will do another, less superficial, review round
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMean.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanLong.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.cpp
Outdated
Show resolved
Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/BrouwerLyddaneMeanShort.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of nit suggestions on adding const
-ness to the return types for the getters of the more trivial types (Angle
/Length
/etc)
...SpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/BrouwerLyddaneMean/BrouwerLyddaneMean.cpp
Show resolved
Hide resolved
...SpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/BrouwerLyddaneMean/BrouwerLyddaneMean.cpp
Show resolved
Hide resolved
...SpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/BrouwerLyddaneMean/BrouwerLyddaneMean.cpp
Show resolved
Hide resolved
...SpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/BrouwerLyddaneMean/BrouwerLyddaneMean.cpp
Show resolved
Hide resolved
...SpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/BrouwerLyddaneMean/BrouwerLyddaneMean.cpp
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/COE.hpp
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/COE.hpp
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/COE.hpp
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/COE.hpp
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit/Models/Kepler/COE.hpp
Show resolved
Hide resolved
Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
* feat: add python bindings * docs: add docstring cpp * feat: finish tests, docstrings and bindings --------- Co-authored-by: vishwa shah <vishwa2710@gmail.com>
1e47f44
to
51c8a07
Compare