Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start bindings and add docstrings #242

Conversation

Derollez
Copy link
Contributor

No description provided.

@Derollez Derollez requested a review from vishwa2710 October 12, 2023 15:37
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #242 (8e2f4fd) into users/vishwa/add-mean-elements (1e20615) will not change coverage.
Report is 2 commits behind head on users/vishwa/add-mean-elements.
The diff coverage is n/a.

❗ Current head 8e2f4fd differs from pull request most recent head b0d0586. Consider uploading reports for the commit b0d0586 to get more accurate results

@@                       Coverage Diff                       @@
##           users/vishwa/add-mean-elements     #242   +/-   ##
===============================================================
  Coverage                           82.94%   82.94%           
===============================================================
  Files                                  66       66           
  Lines                                5431     5431           
===============================================================
  Hits                                 4505     4505           
  Misses                                926      926           

@vishwa2710 vishwa2710 force-pushed the users/remy/quick-push-mean-elements-vishwa-remaining-steps branch from b0d0586 to 5674f2f Compare October 12, 2023 22:18
@vishwa2710 vishwa2710 merged commit 0e1d655 into users/vishwa/add-mean-elements Oct 12, 2023
@vishwa2710 vishwa2710 deleted the users/remy/quick-push-mean-elements-vishwa-remaining-steps branch October 12, 2023 22:18
vishwa2710 added a commit that referenced this pull request Oct 13, 2023
* feat: add python bindings

* docs: add docstring cpp

* feat: finish tests, docstrings and bindings

---------

Co-authored-by: vishwa shah <vishwa2710@gmail.com>
vishwa2710 added a commit that referenced this pull request Oct 13, 2023
* wip:

* feat: get it working

* feat: working cut

* feat: Add BrouwerLyddaneMeanShort + tests

* feat: add tests for apo/periapsis calculation

* feat: more tests

* feat: address feedback

* Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* feat: start bindings and add docstrings (#242)

* feat: add python bindings

* docs: add docstring cpp

* feat: finish tests, docstrings and bindings

---------

Co-authored-by: vishwa shah <vishwa2710@gmail.com>

* refactor: move some stuff around

* chore: cleanup

---------

Co-authored-by: Vishwa Shah <vishwa@loftorbital.com>
Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
Co-authored-by: Remy Derollez <43561754+Derollez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants