Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev container to better enable cpp and python liniting #243

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

apaletta3
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #243 (656d421) into main (174cba3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          66       66           
  Lines        5650     5650           
=======================================
  Hits         4728     4728           
  Misses        922      922           

@apaletta3 apaletta3 force-pushed the build/enhance-dev-container-python-linting branch from 0ccbae8 to da04915 Compare October 12, 2023 18:53
@apaletta3 apaletta3 force-pushed the build/enhance-dev-container-python-linting branch 2 times, most recently from 3c7a43b to 82c302b Compare October 16, 2023 11:53
@apaletta3 apaletta3 changed the title chore: remove unnecessary linting warning when developing in dev container chore: update dev container to better enable cpp and python liniting Oct 16, 2023
@apaletta3 apaletta3 removed the request for review from lucas-bremond October 16, 2023 11:54
@apaletta3 apaletta3 force-pushed the build/enhance-dev-container-python-linting branch from cc1efbd to 8534b12 Compare October 22, 2023 22:28
@apaletta3
Copy link
Contributor Author

@vishwa2710 did you want to add anything linting/intellisense wise to this PR or should I land it?

@apaletta3 apaletta3 force-pushed the build/enhance-dev-container-python-linting branch from 8534b12 to 656d421 Compare October 27, 2023 12:35
Copy link
Contributor

@phc1990 phc1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phc1990 phc1990 merged commit ab528cf into main Oct 27, 2023
11 checks passed
@phc1990 phc1990 deleted the build/enhance-dev-container-python-linting branch October 27, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants