feat: make the propagator maintain the frame and size of the input State #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate in the output
vishwa2710
approved these changes
Oct 14, 2023
Co-authored-by: Vishwa Shah <vishwa2710@gmail.com>
phc1990
reviewed
Oct 16, 2023
include/OpenSpaceToolkit/Astrodynamics/Trajectory/Propagator.hpp
Outdated
Show resolved
Hide resolved
…x errors from uncommenting code
phc1990
approved these changes
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 83.64% 83.67% +0.02%
==========================================
Files 66 66
Lines 5639 5647 +8
==========================================
+ Hits 4717 4725 +8
Misses 922 922
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the propagator converts any input state into the correct dimensions and Frame to propagate.
This is fine, but get's confusing when you pass in a higher dimensional State in ITRF and get back a lower dimensional one in GCRF.
This MR introduces a layer that transforms the input/output State to/from the State that the numerical solver uses using the new StateBuilder class.