Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata for segment and sequence solutions #250

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 self-assigned this Oct 16, 2023
@vishwa2710 vishwa2710 force-pushed the users/vishwa/add-sequence-segment-solution-metadata branch from da04ad7 to 0207879 Compare October 16, 2023 21:54
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #250 (94565ce) into main (caaddaa) will increase coverage by 0.10%.
The diff coverage is 98.43%.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   83.39%   83.50%   +0.10%     
==========================================
  Files          66       66              
  Lines        5505     5546      +41     
==========================================
+ Hits         4591     4631      +40     
- Misses        914      915       +1     
Files Coverage Δ
...nSpaceToolkit/Astrodynamics/Trajectory/Segment.hpp 100.00% <ø> (ø)
...SpaceToolkit/Astrodynamics/Trajectory/Sequence.hpp 100.00% <ø> (ø)
src/OpenSpaceToolkit/Astrodynamics/Dynamics.cpp 100.00% <100.00%> (ø)
...SpaceToolkit/Astrodynamics/Trajectory/Sequence.cpp 100.00% <100.00%> (ø)
...Astrodynamics/Trajectory/State/NumericalSolver.cpp 97.34% <100.00%> (-0.14%) ⬇️
...nSpaceToolkit/Astrodynamics/Trajectory/Segment.cpp 98.90% <96.77%> (-1.10%) ⬇️

Copy link
Contributor

@kyle-cochran kyle-cochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Sick dude!

Copy link
Contributor Author

@vishwa2710 vishwa2710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick catches. Thanks man!

src/OpenSpaceToolkit/Astrodynamics/Trajectory/Segment.cpp Outdated Show resolved Hide resolved
@vishwa2710 vishwa2710 enabled auto-merge (squash) October 17, 2023 06:10
@vishwa2710 vishwa2710 merged commit d4aae19 into main Oct 17, 2023
11 of 12 checks passed
@vishwa2710 vishwa2710 deleted the users/vishwa/add-sequence-segment-solution-metadata branch October 17, 2023 06:32
vishwa2710 added a commit that referenced this pull request Oct 17, 2023
* feat: add metadata for segment and sequence solutions

* chore: missed a spot

* feat: fix test typo

* Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* chore: address remaining feedback

* chore: missed a spot

---------

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
vishwa2710 added a commit that referenced this pull request Oct 17, 2023
* feat: add metadata for segment and sequence solutions

* chore: missed a spot

* feat: fix test typo

* Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* chore: address remaining feedback

* chore: missed a spot

---------

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
vishwa2710 added a commit that referenced this pull request Oct 17, 2023
…ns) (#251)

* feat: add metadata for segment and sequence solutions

* wip:

* feat: use boost log for logging Sequences

* feat: improve printing everywhere and update logging

* Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* feat: address remaining feedback and add tests

* feat: add metadata for segment and sequence solutions (#250)

* feat: add metadata for segment and sequence solutions

* chore: missed a spot

* feat: fix test typo

* Apply suggestions from code review

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* chore: address remaining feedback

* chore: missed a spot

---------

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>

* chore: fix static library boost log

---------

Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants