fix: update README Eigen version and add {fmt} dependency #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,7 +225,8 @@ Benchmarks are pushed to the [GitHub pages](https://open-space-collective.github | |||
| | ----------- | --------- | ------------------ | ------------------------------------------------------------------------------------------------------------------------------------------ | | |||
| | Pybind11 | `2.10.1` | BSD-3-Clause | [github.com/pybind/pybind11](https://github.com/pybind/pybind11) | | |||
| | ordered-map | `0.6.0` | MIT | [github.com/Tessil/ordered-map](https://github.com/Tessil/ordered-map) | | |||
| | Eigen | `3.3.7` | MPL2 | [eigen.tuxfamily.org](http://eigen.tuxfamily.org/index.php) | | |||
| | {fmt} | `5.2.0` | BSD-2-Clause | [github.com/fmtlib/fmt](https://github.com/fmtlib/fmt) | | |||
There was a problem hiding this comment.
Thanks for updating! Actually, fmt is already listed as an OSTk Core dependency this is why it isn't duplicated here.
However, the Eigen version bump is valid, thanks for spotting that!
There was a problem hiding this comment.
Thank you for your comment!
OTSK-physics and OTSK-mathematics lists core and {fmt} as a dependency, hence I suggested the change to be consistent with other repos.
There was a problem hiding this comment.
Good point. If we want these lists to match the Dockerfiles, then indeed we may want to add {fmt} here? Or should they rather match CMakeLists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README to be consistent with the Eigen version stated in the development docker file and to add the explicit dependence on fmt.