Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align release dockerfile with ostk-data seeding paradigm #258

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

apaletta3
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-cochran couple questions for you

docker/release/Dockerfile Show resolved Hide resolved
docker/release/Dockerfile Outdated Show resolved Hide resolved
docker/release/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor Author

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-cochran couple questions for you

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #258 (9197078) into main (f964cf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          66       66           
  Lines        5650     5650           
=======================================
  Hits         4728     4728           
  Misses        922      922           

@apaletta3
Copy link
Contributor Author

@kyle-cochran made updates based on our comments. lmk if it looks good!

@apaletta3 apaletta3 changed the title fix: add atmospheric env variable to release dockerfile chore: align release dockerfile with ostk-data seeding paradigm Oct 22, 2023
@apaletta3 apaletta3 force-pushed the chore/update-dockerfile branch from 6964a60 to 9197078 Compare October 22, 2023 22:24
@apaletta3 apaletta3 enabled auto-merge (squash) October 22, 2023 22:25
@apaletta3 apaletta3 merged commit 30ca4aa into main Oct 22, 2023
@apaletta3 apaletta3 deleted the chore/update-dockerfile branch October 22, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants