feat: update finite difference solver callable interface #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 84.01% 84.02% +0.01%
==========================================
Files 68 68
Lines 5835 5842 +7
==========================================
+ Hits 4902 4909 +7
Misses 933 933
|
kyle-cochran
approved these changes
Nov 3, 2023
bindings/python/src/OpenSpaceToolkitAstrodynamicsPy/Solvers/FiniteDifferenceSolver.cpp
Outdated
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Solvers/FiniteDifferenceSolver.hpp
Outdated
Show resolved
Hide resolved
include/OpenSpaceToolkit/Astrodynamics/Solvers/FiniteDifferenceSolver.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: kyle-cochran <kyle.ray.cochran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the callable interface to return coordinates so that it's easier to generate the STM/Gradient. It's a bit annoying to create a state when we're only using the coordinates. Also, in cases like QLaw, we're finite differencing abstract concepts like the Q value where it doesn't make sense to create a fake state for it.