chore: cache mass flow rate #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaletta3
requested changes
Nov 21, 2023
There was a problem hiding this comment.
The test that doesn't pass can be fixed on line 99 of Thurster.test.cpp by changing it to this
EXPECT_THROW(Thruster(SatelliteSystem::Undefined(), defaultGuidanceLaw_, defaultName_), ostk::core::error::runtime::Undefined);
However, I'm not sure that's exactly the behavior you want here since it fails during construction, before you even get to use the .getSatelliteSystem(). So you might have to change something in the SatelliteSystem class for it to behave correctly.
vishwa2710
force-pushed
the
users/vishwa/chore-cleanup-thruster-naming
branch
from
d1697d5 to
82fcc57
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 71 71
Lines 6059 6060 +1
=======================================
+ Hits 5165 5166 +1
Misses 894 894 ☔ View full report in Codecov by Sentry. |
vishwa2710
force-pushed
the
users/vishwa/chore-cleanup-thruster-naming
branch
from
82fcc57 to
719ecae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.