Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve-makefile-and-dev-experience #282

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

apaletta3
Copy link
Contributor

@apaletta3 apaletta3 commented Nov 22, 2023

This MR aims to make the ostk dev experience better by streamlining the build/make process by improving the makefile:

  • allow the make debug-jupyter-notebook target to build and cache the binaries for the locally modified source code everytime you run that command, instead of needing to spin up a development container and build/re-build before re-launching jupyter
  • make clean now removes all build/lib/package/etc folders to actually clean things properly

The part that hasn't been done yet is to fix container users so that we aren't root inside the container, which causes issues when working inside and outside the container since the hosts' files are now changed owners. This might become a little difficult because CMake doesn't seem to like being run from a non-root user.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (020abdf) 85.24% compared to head (c862325) 85.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files          71       71           
  Lines        6060     6060           
=======================================
  Hits         5166     5166           
  Misses        894      894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@apaletta3 apaletta3 self-assigned this Nov 22, 2023
@apaletta3 apaletta3 requested a review from vishwa2710 November 23, 2023 12:30
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@apaletta3 apaletta3 force-pushed the chore/improve-makefile-dev-experience branch from 351df0d to c862325 Compare November 27, 2023 17:55
@apaletta3 apaletta3 marked this pull request as ready for review November 27, 2023 17:55
@apaletta3 apaletta3 enabled auto-merge (squash) November 27, 2023 17:57
@apaletta3 apaletta3 merged commit 93ab772 into main Nov 27, 2023
11 checks passed
@apaletta3 apaletta3 deleted the chore/improve-makefile-dev-experience branch November 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants