-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve-makefile-and-dev-experience #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 71 71
Lines 6060 6060
=======================================
Hits 5166 5166
Misses 894 894 ☔ View full report in Codecov by Sentry. |
vishwa2710
reviewed
Nov 22, 2023
vishwa2710
approved these changes
Nov 27, 2023
Co-authored-by: Vishwa Shah <vishwa2710@gmail.com>
Co-authored-by: Vishwa Shah <vishwa2710@gmail.com>
apaletta3
force-pushed
the
chore/improve-makefile-dev-experience
branch
from
November 27, 2023 17:55
351df0d
to
c862325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to make the ostk dev experience better by streamlining the build/make process by improving the makefile:
make debug-jupyter-notebook
target to build and cache the binaries for the locally modified source code everytime you run that command, instead of needing to spin up a development container and build/re-build before re-launching jupyterThe part that hasn't been done yet is to fix container users so that we aren't root inside the container, which causes issues when working inside and outside the container since the hosts' files are now changed owners. This might become a little difficult because CMake doesn't seem to like being run from a non-root user.