Skip to content

refactor: namespace derived structs within parents for python bindings #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f06942c) 85.25% compared to head (bdbbdc2) 85.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          71       71           
  Lines        6068     6068           
=======================================
  Hits         5173     5173           
  Misses        895      895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishwa2710 vishwa2710 force-pushed the users/vishwa/fix-binding-namespacing branch from ba6768a to bdbbdc2 Compare November 28, 2023 00:51
Copy link
Contributor

@Derollez Derollez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Derollez Derollez merged commit 2ffa10e into main Nov 28, 2023
@Derollez Derollez deleted the users/vishwa/fix-binding-namespacing branch November 28, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants