Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use eta variables for return statement to remove build warning #292

Merged
merged 1 commit into from
Dec 4, 2023
Merged

chore: use eta variables for return statement to remove build warning #292

merged 1 commit into from
Dec 4, 2023

Conversation

Derollez
Copy link
Contributor

@Derollez Derollez commented Dec 4, 2023

  • Remove build warning (nit)

@Derollez Derollez requested a review from apaletta3 December 4, 2023 11:24
apaletta3
apaletta3 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@apaletta3 apaletta3 changed the title chore: use eta variables for return statement chore: use eta variables for return statement to remove build warning Dec 4, 2023
@apaletta3 apaletta3 enabled auto-merge (squash) December 4, 2023 11:26
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (306b07e) 85.75% compared to head (cf98458) 85.77%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   85.75%   85.77%   +0.01%     
==========================================
  Files          71       71              
  Lines        6306     6304       -2     
==========================================
- Hits         5408     5407       -1     
+ Misses        898      897       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaletta3 apaletta3 merged commit 1be8bfd into main Dec 4, 2023
11 checks passed
@apaletta3 apaletta3 deleted the users/remy/remove-build-warning branch December 4, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaletta3 apaletta3 apaletta3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Derollez @apaletta3