Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more pass computation methods #414

Merged
merged 18 commits into from
Jun 26, 2024

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 self-assigned this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.08%. Comparing base (6a2e303) to head (928e947).

Files Patch % Lines
...ceToolkit/Astrodynamics/Trajectory/Orbit/Model.cpp 0.00% 11 Missing ⚠️
...penSpaceToolkit/Astrodynamics/Trajectory/Orbit.cpp 97.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   90.96%   91.08%   +0.11%     
==========================================
  Files          84       84              
  Lines        7937     7973      +36     
==========================================
+ Hits         7220     7262      +42     
+ Misses        717      711       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few things to polish up, but otherwise looks good!

bindings/python/requirements.txt Outdated Show resolved Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit.cpp Outdated Show resolved Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit.cpp Outdated Show resolved Hide resolved
src/OpenSpaceToolkit/Astrodynamics/Trajectory/Orbit.cpp Outdated Show resolved Hide resolved
@vishwa2710 vishwa2710 force-pushed the feat/add-more-pass-computation-methods branch from af20a55 to 2d15336 Compare June 25, 2024 21:31
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can address my comments, otherwise looks dope man

@vishwa2710 vishwa2710 merged commit 6687920 into main Jun 26, 2024
14 checks passed
@vishwa2710 vishwa2710 deleted the feat/add-more-pass-computation-methods branch June 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants