Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix C++17 build #450

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: fix C++17 build #450

merged 1 commit into from
Oct 21, 2024

Conversation

tapiab
Copy link
Contributor

@tapiab tapiab commented Oct 21, 2024

This PR fixes C++17 build

Summary by CodeRabbit

  • Chores
    • Updated the build system configuration for improved C++ version support.
    • Simplified handling of debug symbols and installation paths.
    • Clarified architecture-specific includes for stack traces.

Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

Walkthrough

The changes in this pull request primarily involve modifications to the CMakeLists.txt file for the OpenSpaceToolkitAstrodynamics project. Key adjustments include the removal of the C++ compiler warning settings, a new conditional structure for C++ standard support, simplified debug symbol configurations, and clarified architecture-specific include handling. The overall structure of the build configuration remains intact, ensuring compatibility with existing dependencies and installation paths.

Changes

File Change Summary
CMakeLists.txt Removed C++ compiler warnings section; adjusted C++ standard handling for C++17 and C++20; simplified debug symbols configuration; clarified architecture-specific includes; preserved sections for libraries and tests.

Possibly related PRs

  • feat: force C++17 for aarch64 build #447: The changes in this PR also modify the CMake configuration for C++ standard handling, specifically addressing how C++17 and C++20 are enabled based on build options, which is directly related to the adjustments made in the main PR.

Suggested reviewers

  • vishwa2710

Poem

In the land of code, where rabbits play,
CMake's been changed in a clever way.
No more strict warnings, just options to choose,
C++ standards now dance, no chance to lose.
With paths set right, and symbols so clear,
Our builds will hop high, with nothing to fear! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e10104b and 094cc1d.

📒 Files selected for processing (1)
  • CMakeLists.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • CMakeLists.txt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tapiab tapiab self-assigned this Oct 21, 2024
@vishwa2710 vishwa2710 enabled auto-merge (squash) October 21, 2024 19:47
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (e10104b) to head (094cc1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          85       85           
  Lines        8618     8618           
=======================================
  Hits         7836     7836           
  Misses        782      782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishwa2710 vishwa2710 disabled auto-merge October 21, 2024 20:05
@vishwa2710 vishwa2710 enabled auto-merge (squash) October 21, 2024 20:05
@vishwa2710 vishwa2710 merged commit 3a0487a into main Oct 21, 2024
15 checks passed
@vishwa2710 vishwa2710 deleted the tapiab/fix-c++17-build branch October 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants