-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update mathematics to 4.3 and physics to 11.1 #465
build: update mathematics to 4.3 and physics to 11.1 #465
Conversation
WalkthroughThe changes involve updating the version specifications for two dependencies in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RequirementsFile
participant CMakeLists
participant Dockerfile
participant DependencyManager
User->>RequirementsFile: Update versions
User->>CMakeLists: Update package version
User->>Dockerfile: Update major version
RequirementsFile->>DependencyManager: New versions specified
CMakeLists->>DependencyManager: New package version required
Dockerfile->>DependencyManager: Install updated dependencies
DependencyManager->>User: Install updated dependencies
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (2)docker/development/Dockerfile (2)
Update mathematics major version to match requirements.txt While updating physics to version 11, the mathematics version update (4.2 -> 4.3) mentioned in requirements.txt is not reflected in the Dockerfile's Apply this diff to maintain consistency: -ARG OSTK_PHYSICS_MAJOR="11"
+ARG OSTK_MATHEMATICS_MAJOR="4" # Should be updated if 4.3 requires a different major version
+ARG OSTK_PHYSICS_MAJOR="11"
The major version bump for physics (10 -> 11) might introduce breaking changes. Please ensure:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 85 85
Lines 8639 8639
=======================================
Hits 7872 7872
Misses 767 767 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
open-space-toolkit-mathematics
andopen-space-toolkit-physics
.