fix: downgrade physics dep. to 10.1 #467
Conversation
WalkthroughThe changes in this pull request primarily involve downgrading the required version of the Open Space Toolkit Physics package from version "11" to "10" across multiple files, including Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (2)docker/development/Dockerfile (1)
The change aligns with the PR objective to downgrade the Open Space Toolkit Physics package to version 10. Let's verify compatibility with other OSTK components: ✅ Verification successfulDowngrade to Physics v10 is compatible with other OSTK components The verification shows that all other OSTK components (Core, I/O, Mathematics) are at major version 4, which is compatible with Physics v10. This is a safe downgrade as Physics v10 was designed to work with OSTK v4 components. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check version compatibility between OSTK components
# Get latest v10.x.x tag for Physics
PHYSICS_LATEST=$(curl -s "https://api.github.com/repos/open-space-collective/open-space-toolkit-physics/git/matching-refs/tags/10" | jq -r '.[-1].ref' | cut -d "/" -f3)
# Check dependencies in Physics v10 release
echo "Checking dependencies for Physics v${PHYSICS_LATEST}..."
curl -s "https://raw.githubusercontent.com/open-space-collective/open-space-toolkit-physics/${PHYSICS_LATEST}/CMakeLists.txt" | grep -A 5 "find_package.*open-space-toolkit"
Length of output: 436 Script: #!/bin/bash
# Let's check the current OSTK component versions in the Dockerfile
rg "ARG OSTK_.*_MAJOR" docker/development/Dockerfile
# Also check CMakeLists.txt for OSTK dependencies
fd CMakeLists.txt --exec cat {} \; | rg "find_package.*open-space-toolkit"
Length of output: 239 CMakeLists.txt (1)
Verify compatibility with the downgraded Physics dependency. Downgrading from version 11 to 10 is a major version change that could introduce compatibility issues. Please ensure:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
phc1990
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 85 85
Lines 8639 8639
=======================================
Hits 7872 7872
Misses 767 767 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
Bug Fixes
open-space-toolkit-physicsto ensure stability.Chores